Fixed XB Banner - Extra CSS with only comments doesn't compile

dgibs

Customer
If extra box has only commented lines it fails to compile. If extra box is blank or at least one line isn't commented it compiles fine.
1623940185231.png

Code:
XF\CssRenderException: Error rendering template public:xb.less: ParseError: missing closing `}` in public:xb.less on line 5418, column 2 (on or near line 5418) src/XF/CssRenderException.php:87
Generated by: Unknown account Jun 17, 2021 at 10:06 AM
Stack trace
 5415 | .p-body-pageContent .block
 5416 | {
 5417 |     .block-container
*5418*|     {
 5419 |         border-width: 0;
 5420 |     }
 5421 | }
------------

#0 src/XF/CssRenderer.php(416): XF\CssRenderException::createFromLessException(Object(Less_Exception_Chunk), 'public:xb.less', '// Note that th...')
#1 src/XF/CssRenderer.php(350): XF\CssRenderer->renderToCss('public:xb.less', '// Note that th...')
#2 src/XF/CssRenderer.php(258): XF\CssRenderer->renderTemplate('public:xb.less', NULL)
#3 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates(Array, Array, Array)
#4 src/XF/CssWriter.php(53): XF\CssRenderer->render(Array)
#5 src/addons/SV/RedisCache/XF/CssWriter.php(52): XF\CssWriter->run(Array, 25, 1, 'f847a41097e9bd7...')
#6 css.php(30): SV\RedisCache\XF\CssWriter->run(Array, 25, 1, 'f847a41097e9bd7...')
#7 {main}

-------------

Previous Less_Exception_Chunk: ParseError: missing closing `}` in anonymous-file-0.less on line 5418, column 2
5416| {
5417|     .block-container
5418|     {
5419|         border-width: 0;
5420|     }
5421| } - src/vendor/oyejorge/less.php/lib/Less/Parser.php:677
#0 src/vendor/oyejorge/less.php/lib/Less/Parser.php(621): Less_Parser->GetRules(NULL)
#1 src/vendor/oyejorge/less.php/lib/Less/Parser.php(449): Less_Parser->_parse()
#2 src/XF/CssRenderer.php(412): Less_Parser->parse('// Note that th...')
#3 src/XF/CssRenderer.php(350): XF\CssRenderer->renderToCss('public:xb.less', '// Note that th...')
#4 src/XF/CssRenderer.php(258): XF\CssRenderer->renderTemplate('public:xb.less', NULL)
#5 src/XF/CssRenderer.php(116): XF\CssRenderer->renderTemplates(Array, Array, Array)
#6 src/XF/CssWriter.php(53): XF\CssRenderer->render(Array)
#7 src/addons/SV/RedisCache/XF/CssWriter.php(52): XF\CssWriter->run(Array, 25, 1, 'f847a41097e9bd7...')
#8 css.php(30): SV\RedisCache\XF\CssWriter->run(Array, 25, 1, 'f847a41097e9bd7...')
#9 {main}
 

Russ

Pixel Exit Staff
This popped up in the past and it completely slipped my mind to follow up with XenForo on it. To be honest, I do not know why it doesn't work. You can either remove the code or simply use standard CSS comments:

suzSnif.png


I'm writing the XenForo team now.
 

dgibs

Customer
So what are "//" comments? And why do they show it as commented in editor, just curious. thanks, david
 

Russ

Pixel Exit Staff
I've submitted a bug report:

It's from LESS (the CSS system XenForo uses):

Single-line comments are also valid in LESS, but they are ‘silent’, they don’t show up in the compiled CSS output
 

Russ

Pixel Exit Staff
XF came back with as-designed due to how it's processed. I have made a change to the CSS to avoid this in the future. Fixed in 2.2.6.

The banners + prefix CSS has turned from:

Code:
&.userBanner--staff { .xf-xbBannerStaff(); }
To:
Code:
    &.userBanner--staff
    {
        .xf-xbBannerStaff();
    }
 

Pre-Sale Questions

If you have any questions or concerns you want to ask before you make a purchase don't hesitate to use one of our multiple support channels for your convenience.