Not a Bug XF 2.3.5 Error report

[duderuud]

Looks like it is caused by our (custom) style:

ErrorException: [E_NOTICE] Object of class Less_Tree_Dimension could not be converted to int
src/vendor/oyejorge/less.php/lib/Less/Functions.php:36
Generated by: Unknown account
Jan 30, 2025 at 6:40 PM

Stack trace

#0 [internal function]: XF::handlePhpError(8, '[E_NOTICE] Obje...', '/home/nginx/dom...', 36)
#1 src/vendor/oyejorge/less.php/lib/Less/Functions.php(36): max(Object(Less_Tree_Dimension), 0)
#2 src/vendor/oyejorge/less.php/lib/Less/Tree/Call.php(76): Less_Functions::clamp(Object(Less_Tree_Dimension), Object(Less_Tree_Call), Object(Less_Tree_Dimension))
#3 src/vendor/oyejorge/less.php/lib/Less/Tree/Operation.php(26): Less_Tree_Call->compile(Object(Less_Environment))
#4 src/vendor/oyejorge/less.php/lib/Less/Tree/Call.php(40): Less_Tree_Operation->compile(Object(Less_Environment))
#5 src/XF/Less/Tree/HslColor.php(225): Less_Tree_Call->compile(Object(Less_Environment))
#6 [internal function]: XF\Less\Tree\HslColor->XF\Less\Tree\{closure}(Object(Less_Tree_Call))
#7 src/XF/Less/Tree/HslColor.php(217): array_map(Object(Closure), Array)
#8 src/vendor/oyejorge/less.php/lib/Less/Tree/Mixin/Definition.php(110): XF\Less\Tree\HslColor->compile(Object(Less_Environment))
#9 src/vendor/oyejorge/less.php/lib/Less/Tree/Mixin/Definition.php(161): Less_Tree_Mixin_Definition->compileParams(Object(Less_Environment), Array, Array, Array)
#10 src/vendor/oyejorge/less.php/lib/Less/Tree/Mixin/Call.php(127): Less_Tree_Mixin_Definition->evalCall(Object(Less_Environment), Array, NULL)
#11 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(147): Less_Tree_Mixin_Call->compile(Object(Less_Environment))
#12 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(90): Less_Tree_Ruleset->EvalMixinCalls(Object(Less_Tree_Ruleset), Object(Less_Environment), 1)
#13 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(95): Less_Tree_Ruleset->compile(Object(Less_Environment))
#14 src/vendor/oyejorge/less.php/lib/Less/Tree/Ruleset.php(95): Less_Tree_Ruleset->compile(Object(Less_Environment))
#15 src/vendor/oyejorge/less.php/lib/Less/Parser.php(181): Less_Tree_Ruleset->compile(Object(Less_Environment))
#16 src/XF/CssRenderer.php(431): Less_Parser->getCss()
#17 src/XF/CssRenderer.php(371): XF\CssRenderer->renderToCss('public:app.less', '// Note that th...')
#18 src/XF/CssRenderer.php(279): XF\CssRenderer->renderTemplate('public:app.less', NULL)
#19 src/XF/CssRenderer.php(135): XF\CssRenderer->renderTemplates(Array, Array, Array)
#20 src/XF/CssWriter.php(60): XF\CssRenderer->render(Array)
#21 src/addons/SV/RedisCache/XF/CssWriter.php(68): XF\CssWriter->run(Array, 28, 2, '7359f9234281cec...')
#22 css.php(32): SV\RedisCache\XF\CssWriter->run(Array, 28, 2, '7359f9234281cec...')
#23 {main}

Request state

array(4) {
["url"] => string(186) "/css.php?css=public%3Anormalize.css%2Cpublic%3Afa.css%2Cpublic%3Avariations.less%2Cpublic%3Acore.less%2Cpublic%3Aapp.less&s=28&l=2&d=1738251987&k=7359f9234281cece4ea1a6d03950a9f7c0200671"
["referrer"] => string(67) "https://www.domain.com/threads/yamaha-mt-09-2014.362244/page-18"
["_GET"] => array(5) {
["css"] => string(90) "public:normalize.css,public:fa.css,public:variations.less,public:core.less,public:app.less"
["s"] => string(2) "28"
["l"] => string(1) "2"
["d"] => string(10) "1738251987"
["k"] => string(40) "7359f9234281cece4ea1a6d03950a9f7c0200671"
}
["_POST"] => array(0) {
}
}

 

[Russ]

Don't really see anything specific to our style. It's hard to debug with this alone. Is it happening on every page load? Are all of your add-ons updated? Specifically Standard Library + Redis by Xon (it mentions those are the bottom of the stack trace.

 

[duderuud]

No, it's not happening on all pages. No errors in 30 minutes (just cleared log).
All add-ons are up to date. Will report back if errors re-appear.

 

[Russ]

This was a XenForo bug, addressed in 2.3.6. If you see this error and you're running 2.3.6 or newest, best to report it back to XenForo.

 

[duderuud]

2.3.6 indeed fixed it. Thanks for the heads up!